bump core to 2.71.3 in react-docs #4002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
PF4 preview: https://patternfly-react-pr-4002.surge.sh |
redallen
requested review from
ddonahue007,
dlabrecq,
evwilkin,
jschuler,
kmcfaul,
mattnolting,
mcoker,
mturley,
seanforyou23 and
tlabaj
evwilkin
reviewed
Apr 1, 2020
packages/react-core/src/components/ApplicationLauncher/examples/ApplicationLauncher.md
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #4002 +/- ##
==========================================
- Coverage 59.26% 59.26% -0.01%
==========================================
Files 415 415
Lines 6295 6294 -1
Branches 2413 2414 +1
==========================================
- Hits 3731 3730 -1
+ Misses 2098 2096 -2
- Partials 466 468 +2
Continue to review full report at Codecov.
|
tlabaj
requested changes
Apr 1, 2020
packages/react-docs/RELEASE-NOTES.md
Outdated
| - Create variables by file in react-tokens ([#3896](https://github.com/patternfly/patternfly-react/pull/3896)) | ||
| - **Types:** | ||
| - Remove a few usages of prop-types ([#3968](https://github.com/patternfly/patternfly-react/pull/3968)) | ||
| - Fix tippy types, remove copyTS ([#3940](https://github.com/patternfly/patternfly-react/pull/3940)) |
packages/react-docs/RELEASE-NOTES.md
Outdated
| - Remove unused packages from repo ([#3916](https://github.com/patternfly/patternfly-react/pull/3916)) | ||
| - Create variables by file in react-tokens ([#3896](https://github.com/patternfly/patternfly-react/pull/3896)) | ||
| - **Types:** | ||
| - Remove a few usages of prop-types ([#3968](https://github.com/patternfly/patternfly-react/pull/3968)) |
packages/react-docs/RELEASE-NOTES.md
Outdated
| - Release docs to NPM for patternfly-org ([#3941](https://github.com/patternfly/patternfly-react/pull/3941)) | ||
| - **Build:** | ||
| - Created unified react-core dist ([#3971](https://github.com/patternfly/patternfly-react/pull/3971)) | ||
| - In-house focusTrap ([#3967](https://github.com/patternfly/patternfly-react/pull/3967)) |
Contributor
There was a problem hiding this comment.
maybe "Added In-house focusTrap"
Contributor
There was a problem hiding this comment.
That makes sense to me!
packages/react-docs/RELEASE-NOTES.md
Outdated
| - Create variables by file in react-tokens ([#3896](https://github.com/patternfly/patternfly-react/pull/3896)) | ||
| - **Types:** | ||
| - Remove a few usages of prop-types ([#3968](https://github.com/patternfly/patternfly-react/pull/3968)) | ||
| - Fix tippy types, remove copyTS ([#3940](https://github.com/patternfly/patternfly-react/pull/3940)) |
packages/react-docs/RELEASE-NOTES.md
Outdated
| - **Build:** | ||
| - Created unified react-core dist ([#3971](https://github.com/patternfly/patternfly-react/pull/3971)) | ||
| - In-house focusTrap ([#3967](https://github.com/patternfly/patternfly-react/pull/3967)) | ||
| - Remove unused packages from repo ([#3916](https://github.com/patternfly/patternfly-react/pull/3916)) |
Contributor
Author
There was a problem hiding this comment.
I accidentally committed this file. I'll have to update it in the next PR once I know the new version numbers that need to be released.
Contributor
Author
There was a problem hiding this comment.
For now I think the changes it makes are okay... can you approve? It's the thing I'm going to work on right after this gets merged and there's newly released versions. See my message in Slack for the release timeline.
tlabaj
requested changes
Apr 1, 2020
Contributor
tlabaj
left a comment
tlabaj
left a comment
There was a problem hiding this comment.
It also looks like the packages are not updated in the release notes.
|
|
||
| ### Components | ||
| - **About modal:** | ||
| - Allow custom aria-label for the close button ([#3877](https://github.com/patternfly/patternfly-react/pull/3877)) |
Contributor
There was a problem hiding this comment.
Allowed in past tense instead of allow :)
tlabaj
approved these changes
Apr 1, 2020
Contributor
Author
|
@tlabaj @rachael-phillips I did not mean to commit release note changes. I have reverted them and they will be updated in the next PR once I know the right version numbers from releasing this PR. |
Contributor
rachael-phillips
left a comment
rachael-phillips
left a comment
There was a problem hiding this comment.
Hi, I left a few comments. Should be super quick changes!
| - **Empty state:** | ||
| - Added support for extra-large empty state ([#3844](https://github.com/patternfly/patternfly-react/pull/3844)) | ||
| - **Select:** | ||
| - Allow count badge to be hidden in checkbox select ([#3976](https://github.com/patternfly/patternfly-react/pull/3976)) |
Contributor
There was a problem hiding this comment.
Allowed in past tense instead of allow :)
packages/react-docs/RELEASE-NOTES.md
Outdated
| - Release docs to NPM for patternfly-org ([#3941](https://github.com/patternfly/patternfly-react/pull/3941)) | ||
| - **Build:** | ||
| - Created unified react-core dist ([#3971](https://github.com/patternfly/patternfly-react/pull/3971)) | ||
| - In-house focusTrap ([#3967](https://github.com/patternfly/patternfly-react/pull/3967)) |
Contributor
There was a problem hiding this comment.
That makes sense to me!
packages/react-docs/RELEASE-NOTES.md
Outdated
| - Created unified react-core dist ([#3971](https://github.com/patternfly/patternfly-react/pull/3971)) | ||
| - In-house focusTrap ([#3967](https://github.com/patternfly/patternfly-react/pull/3967)) | ||
| - Remove unused packages from repo ([#3916](https://github.com/patternfly/patternfly-react/pull/3916)) | ||
| - Create variables by file in react-tokens ([#3896](https://github.com/patternfly/patternfly-react/pull/3896)) |
|
|
||
| ### Components | ||
| - **About modal:** | ||
| - Allow custom aria-label for the close button ([#3877](https://github.com/patternfly/patternfly-react/pull/3877)) |
| - **Empty state:** | ||
| - Added support for extra-large empty state ([#3844](https://github.com/patternfly/patternfly-react/pull/3844)) | ||
| - **Select:** | ||
| - Allow count badge to be hidden in checkbox select ([#3976](https://github.com/patternfly/patternfly-react/pull/3976)) |
packages/react-docs/RELEASE-NOTES.md
Outdated
| - Create variables by file in react-tokens ([#3896](https://github.com/patternfly/patternfly-react/pull/3896)) | ||
| - Remove unused packages from repo ([#3916](https://github.com/patternfly/patternfly-react/pull/3916)) | ||
| - **Docs:** | ||
| - Release docs to NPM for patternfly-org ([#3941](https://github.com/patternfly/patternfly-react/pull/3941)) |
Contributor
There was a problem hiding this comment.
Moved or Added in front oh phrase
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: For updating Core's release notes in patternfly-org